XML body requests #85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
| Category | Issue | Status |
|---|---|---|
 |
Uncaught XML Parsing Errors ▹ view | ✅ Fix detected |
 |
XML Validation Result Not Used ▹ view | ✅ Fix detected |
 |
Content type handling not extensible ▹ view | ✅ Fix detected |
Files scanned
| File Path | Reviewed |
|---|---|
| src/AbstractRequester.php | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
byjg
requested changes
Jul 2, 2025
src/AbstractRequester.php
Outdated
Comment on lines
254
to
256
| $bodyRequestDef = $this->schema->getRequestParameters($this->psr7Request->getUri()->getPath(), $this->psr7Request->getMethod()); | ||
| $bodyRequestDef->match($requestBody); | ||
| } |
There was a problem hiding this comment.
Suggested change
| $bodyRequestDef = $this->schema->getRequestParameters($this->psr7Request->getUri()->getPath(), $this->psr7Request->getMethod()); | |
| $bodyRequestDef->match($requestBody); | |
| } | |
| // Check if the body is the expected before request | |
| $bodyRequestDef = $this->schema->getRequestParameters($this->psr7Request->getUri()->getPath(), $this->psr7Request->getMethod()); | |
| $bodyRequestDef->match($requestBody); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description by Korbit AI
What change is being made?
Add support for XML body requests in the
AbstractRequesterby integrating thebyjg/xmlutillibrary, updating content type parsing logic, and introducing a test case for handling XML request bodies.Why are these changes being made?
These changes are being made to enhance the request handling capabilities of the
AbstractRequesterby supporting XML payloads, which expands the versatility of the application in processing different content types beyond JSON. This approach utilizes the dependencybyjg/xmlutilto parse and manage XML content efficiently without disrupting existing functionality for JSON and multipart form data.